linux-kernel - Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 11:29:59 -0700
From:   Joe Perches <joe@...ches.com>
To:     Simao Gomes Viana <devel@...erboring.dev>,
        linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by
 checkpatch

On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.

This is too many changes in a single patch to verify
them easily.

If you really want to change this file, and it's likely
not particularly necessary, I suggest that you send a
patch series that where each patch individually does:

1: Horizontal whitespace only changes
   o Trim trailing whitespace
   o Add alignment whitespace
   o Add operator spacing whitespace
2: Vertical whitespace changes if any
3: Convert embedded assignments to multiple lines
4: Comment style updates

And whatever other specific style changes necessary
to properly and easily identify them as correct.