linux-kernel - Re: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200619184049.4fn2rljaay6v7bjy@simao-arch.localdomain>
Date:   Fri, 19 Jun 2020 20:41:04 +0200
From:   Simao Gomes Viana <devel@...erboring.dev>
To:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by
 checkpatch

On Fri, Jun 19, 2020 at 11:29:59AM -0700, Joe Perches wrote:
> On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> > This fixes all errors that scripts/checkpatch.pl
> > reports about drivers/cdrom/*.c and a lot of warnings
> > as well. I skipped warnings that I don't know whether
> > fixing them will break anything.
> 
> This is too many changes in a single patch to verify
> them easily.
> 
> If you really want to change this file, and it's likely
> not particularly necessary, I suggest that you send a
> patch series that where each patch individually does:
> 
> 1: Horizontal whitespace only changes
>    o Trim trailing whitespace
>    o Add alignment whitespace
>    o Add operator spacing whitespace
> 2: Vertical whitespace changes if any
> 3: Convert embedded assignments to multiple lines
> 4: Comment style updates
> 
> And whatever other specific style changes necessary
> to properly and easily identify them as correct.
> 
>

Thank you for your feedback.
I will follow up with a proper set of patches as you 
described in your response.

I'm fairly new to submitting patches. Although I have read
through some of the guidelines there is always room for
improvement so it's great to get feedback like that.