linux-kernel - Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYJeh0-cNbk++CdE664V+2wZirOt1CzfxT-Njp0nq5XxQ@mail.gmail.com>
Date:   Sat, 20 Jun 2020 23:27:08 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Frank Lee <tiny.windzz@...il.com>
Cc:     Maxime Ripard <maxime@...no.tech>, wens <wens@...e.org>,
        李扬韬 <frank@...winnertech.com>,
        "robh+dt" <robh+dt@...nel.org>,
        mturquette <mturquette@...libre.com>, sboyd <sboyd@...nel.org>,
        "p.zabel" <p.zabel@...gutronix.de>,
        黄烁生 <huangshuosheng@...winnertech.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>
Subject: Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

On Tue, Jun 16, 2020 at 11:27 AM Frank Lee <tiny.windzz@...il.com> wrote:
> HI Chen-Yu,  Linus,
> On Fri, Jun 5, 2020 at 11:13 PM Maxime Ripard <maxime@...no.tech> wrote:

> > > Considering that the same pin has multiple same functions,
> > > so add a suffix, like i2s3_dout3 and i2s3_din3?
> > >
> > > Or specify muxsel in the device tree may be another solution.
> >
> > Having muxsel is not really an option. We have two sets of bindings to
> > maintain already, adding a third one would make it fairly hard to
> > maintain. And the second binding we support is the generic pinctrl
> > binding, so I'm not really sure why we would want to move away from
> > that.
> >
> > And I'm not really fond of having a suffix either. It kind of breaks the
> > consistency we had so far, and ideally I'd like to keep that.
> >
> > Chen-Yu, Linus? Any input on that one?

This is entirely up to the driver maintainer. They need to keep the
code together and the naming consistent with how they perceive the
hardware works and/or is intended to work.

Yours,
Linus Walleij