linux-kernel - Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200621062219.GE74146@ravnborg.org>
Date:   Sun, 21 Jun 2020 08:22:19 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Adam Ford <aford173@...il.com>
Cc:     Fabio Estevam <festevam@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Adam Ford-BE <aford@...conembedded.com>,
        stable <stable@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28
 Display

Hi Adam.

On Mon, Jun 15, 2020 at 09:53:45AM -0500, Adam Ford wrote:
> On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam <festevam@...il.com> wrote:
> >
> > On Mon, Jun 15, 2020 at 10:19 AM Adam Ford <aford173@...il.com> wrote:
> > >
> > > The LogicPD Type28 display used by several Logic PD products has not
> > > worked since v5.5.
> >
> > Maybe you could tell which commit exactly and then put a Fixes tag?
> 
> I honestly don't know.  I reached out to the omap mailing list,
> because I noted this issue. Tomi V from TI responded with a link that
> he posted which fixes this for another display.
> 
> https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html
> 
> I tested that patch and it worked for a different LCD, so I did the
> same thing to the Logic PD Type 28 display as well.
> 
> My patch and commit message were modeled after his, and his commit
> CC's stable with a note about being required for v5.5+
> 
> I added him to the CC list, so maybe he knows which hash needs to be
> referenced from a fixes tag.  I was hoping to not have to go back and
> bisect if it's not required, but I will if necessary.

git blame is your friend - the panel was added here:
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2469) static const struct panel_desc logicpd_type_28 = {
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2470)  .modes = &logicpd_type_28_mode,
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2471)  .num_modes = 1,
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2472)  .bpc = 8,
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2473)  .size = {
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2474)          .width = 105,
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2475)          .height = 67,
0d35408afbeb6 (Adam Ford               2019-10-16 08:51:45 -0500 2476)  },

So this gives us fllowing fixes info:
Fixes: 0d35408afbeb ("drm/panel: simple: Add Logic PD Type 28 display support")
Cc: Adam Ford <aford173@...il.com>
Cc: Sam Ravnborg <sam@...nborg.org>
Cc: Thierry Reding <thierry.reding@...il.com>
Cc: dri-devel@...ts.freedesktop.org
Cc: <stable@...r.kernel.org> # v5.6+

I have adjusted the changelog to say 5.6 and applied to drm-misc-fixes

	Sam