linux-kernel - Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jun 2020 15:30:45 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Adam Ford <aford173@...il.com>, Fabio Estevam <festevam@...il.com>
CC:     DRI mailing list <dri-devel@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Adam Ford-BE <aford@...conembedded.com>,
        stable <stable@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28
 Display

On 15/06/2020 17:53, Adam Ford wrote:
> On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam <festevam@...il.com> wrote:
>>
>> On Mon, Jun 15, 2020 at 10:19 AM Adam Ford <aford173@...il.com> wrote:
>>>
>>> The LogicPD Type28 display used by several Logic PD products has not
>>> worked since v5.5.
>>
>> Maybe you could tell which commit exactly and then put a Fixes tag?
> 
> I honestly don't know.  I reached out to the omap mailing list,
> because I noted this issue. Tomi V from TI responded with a link that
> he posted which fixes this for another display.
> 
> https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html
> 
> I tested that patch and it worked for a different LCD, so I did the
> same thing to the Logic PD Type 28 display as well.
> 
> My patch and commit message were modeled after his, and his commit
> CC's stable with a note about being required for v5.5+
> 
> I added him to the CC list, so maybe he knows which hash needs to be
> referenced from a fixes tag.  I was hoping to not have to go back and
> bisect if it's not required, but I will if necessary.

No, I didn't check when exactly it broke. connector_type was added in v5.5, and my patch applies to 
v5.5, so I set that as stable version. But the WARN comes from panel bridge. Possibly 
89958b7cd9555a5d82556cc9a1f4c62fffda6f96 is the one that adds requirement to have connector_type.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki