linux-kernel - Re: [PATCH v2] clk: at91: add sama5d3 pmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622214759.GK131826@piout.net>
Date:   Mon, 22 Jun 2020 23:47:59 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org,
        Karl Rudbæk Olsen <karl@...ro-technic.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] clk: at91: add sama5d3 pmc driver

Hi,

On 22/06/2020 23:24:45+0200, Ahmad Fatoum wrote:
> > +	regmap = syscon_node_to_regmap(np);
> 
> Shouldn't this be device_node_to_regmap for the same reasons outlined in your
> 6956eb33 ("clk: at91: fix possible deadlock") commit?
> 
> Same question for at91sam9g45.c, sam9x60.c and at91sam9n12.c.
> 

Agreed, I guess you can send a patch fixing all the instances.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com