linux-kernel - Re: [PATCH v2] clk: at91: add sama5d3 pmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Jul 2020 09:34:43 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org,
        Karl Rudbæk Olsen <karl@...ro-technic.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] clk: at91: add sama5d3 pmc driver

Hello Alexandre,

On 6/22/20 11:47 PM, Alexandre Belloni wrote:
> Hi,
> 
> On 22/06/2020 23:24:45+0200, Ahmad Fatoum wrote:
>>> +	regmap = syscon_node_to_regmap(np);
>>
>> Shouldn't this be device_node_to_regmap for the same reasons outlined in your
>> 6956eb33 ("clk: at91: fix possible deadlock") commit?
>>
>> Same question for at91sam9g45.c, sam9x60.c and at91sam9n12.c.
>>
> 
> Agreed, I guess you can send a patch fixing all the instances.

I just sent out a patch for those 4 files. I don't know if this issue is equally
applicable to the dt-compat.c code, so I left that one as is.

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |