linux-kernel - Re: [PATCH 28/30] usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to standard comment blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200703073402.GA2336858@kroah.com>
Date:   Fri, 3 Jul 2020 09:34:02 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, Peter Korsgaard <jacmet@...site.dk>,
        Oliver Neukum <oneukum@...e.com>
Subject: Re: [PATCH 28/30] usb: c67x00: c67x00-hcd: Demote obvious misuse of
 kerneldoc to standard comment blocks

On Thu, Jul 02, 2020 at 03:46:23PM +0100, Lee Jones wrote:
> No attempt has been made to document any of the functions here.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'sie' not described in 'c67x00_hcd_irq'
>  drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'int_status' not described in 'c67x00_hcd_irq'
>  drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'msg' not described in 'c67x00_hcd_irq'
>  drivers/usb/c67x00/c67x00-hcd.c:267: warning: Function parameter or member 'hcd' not described in 'c67x00_hcd_start'
>  drivers/usb/c67x00/c67x00-hcd.c:279: warning: Function parameter or member 'hcd' not described in 'c67x00_hcd_stop'
> 
> Cc: Peter Korsgaard <jacmet@...site.dk>
> Cc: Oliver Neukum <oneukum@...e.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/usb/c67x00/c67x00-hcd.c | 6 +++---
>  drivers/usb/class/cdc-wdm.c     | 2 +-

You also tried to fix up the cdc-wdm.c whitespace error in this patch :(

I've dropped this one from the queue as well.

thanks,

greg k-h