linux-kernel - Re: [PATCH v2] nbd: Fix memory leak in nbd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a58ab81-3810-0763-7394-10b51add23ee@web.de>
Date:   Mon, 22 Jun 2020 09:52:22 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Zheng Bin <zhengbin13@...wei.com>, linux-block@...r.kernel.org
Cc:     nbd@...er.debian.org, Aditya Pakki <pakki001@....edu>,
        Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <mccamant@...umn.edu>,
        Qiushi Wu <wu000273@....edu>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Josef Bacik <josef@...icpanda.com>,
        Tuomas Tynkkynen <tuomas.tynkkynen@....fi>,
        Yi Zhang <yi.zhang@...wei.com>
Subject: Re: [PATCH v2] nbd: Fix memory leak in nbd_add_socket

>> Can an other wording variant be nicer?
>
> em, how about this?
>
>
> When adding first socket to nbd,

How do you think about to replace abbreviations by terms?

> if nsock's allocation fails,

… failed,

> config->socks is malloced

The data structure member “config->socks” was reallocated.

> but num_connections does not update,

But the data structure member “config->num_connections” was not updated.

> memory leak will occur(Function
> nbd_config_put will only free config->socks when num_connections is not 0).

A memory leak will occur then because the function “nbd_config_put”
will free “config->socks” only when “num_connections” is not zero.

Would you like to add an imperative wording to the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n151

Regards,
Markus