linux-kernel - Re: [PATCH 2/2] Documentation/litmus-tests: Add note on herd7 7.56 in atomic litmus test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200623232425.GB418699@andrea>
Date:   Wed, 24 Jun 2020 01:24:25 +0200
From:   Andrea Parri <parri.andrea@...il.com>
To:     Akira Yokosawa <akiyks@...il.com>
Cc:     paulmck@...nel.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, kernel-team@...com, mingo@...nel.org,
        stern@...land.harvard.edu, will@...nel.org, peterz@...radead.org,
        boqun.feng@...il.com, npiggin@...il.com, dhowells@...hat.com,
        j.alglave@....ac.uk, luc.maranget@...ia.fr
Subject: Re: [PATCH 2/2] Documentation/litmus-tests: Add note on herd7 7.56
 in atomic litmus test

On Wed, Jun 24, 2020 at 07:09:01AM +0900, Akira Yokosawa wrote:
> From f808c371075d2f92b955da1a83ecb3828db1972e Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@...il.com>
> Date: Wed, 24 Jun 2020 06:59:26 +0900
> Subject: [PATCH 2/2] Documentation/litmus-tests: Add note on herd7 7.56 in atomic litmus test
> 
> herdtools 7.56 has enhanced herd7's C parser so that the "(void)expr"
> construct in Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus is
> accepted.
> 
> This is independent of LKMM's cat model, so mention the required
> version in the header of the litmus test and its entry in README.
> 
> CC: Boqun Feng <boqun.feng@...il.com>
> Reported-by: Andrea Parri <parri.andrea@...il.com>
> Signed-off-by: Akira Yokosawa <akiyks@...il.com>

Frankly, I was hoping that we could simply bump the herd7 version in
tools/memory-model/README; I understand your point, but I admit that
I haven't being playing with 7.52 for a while now...

Acked-by: Andrea Parri <parri.andrea@...il.com>

  Andrea


> ---
>  Documentation/litmus-tests/README                                | 1 +
>  .../atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus       | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Documentation/litmus-tests/README b/Documentation/litmus-tests/README
> index b79e640214b9..7f5c6c3ed6c3 100644
> --- a/Documentation/litmus-tests/README
> +++ b/Documentation/litmus-tests/README
> @@ -19,6 +19,7 @@ Atomic-RMW+mb__after_atomic-is-stronger-than-acquire.litmus
>  
>  Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
>      Test that atomic_set() cannot break the atomicity of atomic RMWs.
> +    NOTE: Require herd7 7.56 or later which supports "(void)expr".
>  
>  
>  RCU (/rcu directory)
> diff --git a/Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus b/Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
> index 49385314d911..ffd4d3e79c4a 100644
> --- a/Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
> +++ b/Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
> @@ -4,6 +4,7 @@ C Atomic-RMW-ops-are-atomic-WRT-atomic_set
>   * Result: Never
>   *
>   * Test that atomic_set() cannot break the atomicity of atomic RMWs.
> + * NOTE: This requires herd7 7.56 or later which supports "(void)expr".
>   *)
>  
>  {
> -- 
> 2.17.1
> 
>