linux-kernel - Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28520c1c-80b6-e955-7c7c-207fb1599683@huawei.com>
Date:   Tue, 23 Jun 2020 14:41:10 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq
 coalesce

On 2020/6/23 6:08, Jakub Kicinski wrote:
>> +	if (coal->tx_max_coalesced_frames > COALESCE_MAX_PENDING_LIMIT) {
>> +		netif_err(nic_dev, drv, netdev,
>> +			  "Tx_max_coalesced_frames out of range[%d-%d]\n", 0,
>> +			  COALESCE_MAX_PENDING_LIMIT);
>> +		return -EOPNOTSUPP;
>> +	}
>> +
>> +	return 0;
>> +}
> I think ERANGE is a more appropriate error code in these?
Will fix. Thanks for your review.