linux-kernel - Re: [PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jun 2020 16:24:25 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 10/10] mfd: wm831x-core: Supply description
 wm831x_reg_{un}lock args

On Wed, Jun 24, 2020 at 04:07:04PM +0100, Lee Jones wrote:
> Kerneldoc syntax is used, but not complete.  Descriptions required.
> 
> Prevents warnings like:
> 
>  drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock'
>  drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_unlock'
> 
> Cc: <stable@...r.kernel.org>
> Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Cc: patches@...nsource.cirrus.com
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles