linux-kernel - Re: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62pJZbHXwbKc36qJ=dATHyZDU=yw6Z+krWi47AJmotqEvA@mail.gmail.com>
Date:   Thu, 25 Jun 2020 10:46:37 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol
 'sprd_pmic_detect_charger_type' was not declared warning

Hi Lee,

On Wed, Jun 24, 2020 at 11:07 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Sparse reports:
>
>  drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static?
>
> ... due to a missing header file.
>
> Cc: <stable@...r.kernel.org>
> Cc: Orson Zhai <orsonzhai@...il.com>
> Cc: Baolin Wang <baolin.wang7@...il.com>
> Cc: Chunyan Zhang <zhang.lyra@...il.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@...il.com>

> ---
>  drivers/mfd/sprd-sc27xx-spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 33336cde47243..c305e941e435c 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -7,6 +7,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/mfd/core.h>
> +#include <linux/mfd/sc27xx-pmic.h>
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>
>  #include <linux/spi/spi.h>
> --
> 2.25.1
>


-- 
Baolin Wang