linux-kernel - Re: [PATCH] Bluetooth: btusb: BTUSB_WAKEUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <51656AF4-EB93-44D1-8C1E-CD00A2BBA781@holtmann.org>
Date:   Wed, 24 Jun 2020 20:29:08 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     linux-bluetooth@...r.kernel.org,
        chromeos-bluetooth-upstreaming@...omium.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: BTUSB_WAKEUP_DISABLE prevents wake

Hi Abhishek,

> When the BTUSB_WAKEUP_DISABLE flag is set, always return true for
> prevent wake. This tells the suspend notifier not to prepare the
> controller for reconnections during suspend.
> 
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> ---
> Realtek chipsets currently lose their firmware when suspending (except
> in autosuspend where they assert remote_wakeup on the usb interface).
> There's no need to configure the Bluetooth stack for wake-up in this
> case so use the BTUSB_WAKEUP_DISABLE flag to also prevent wakeup from
> being configured.
> 
> This was tested on Chromebooks with Realtek chipsets running both 4.14
> and 5.4 kernel. It was tested with suspend functional tests and
> a suspend stress test for 50 iterations.
> 
> drivers/bluetooth/btusb.c | 3 +++
> 1 file changed, 3 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel