linux-kernel - Re: [1/7] irqchip: Fix potential resource leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd28aef9-ba70-0539-bdc3-6ce7162cefca@loongson.cn>
Date:   Wed, 24 Jun 2020 17:16:50 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Markus Elfring <Markus.Elfring@....de>, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Huacai Chen <chenhc@...ote.com>,
        Jason Cooper <jason@...edaemon.net>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [1/7] irqchip: Fix potential resource leaks

On 06/24/2020 04:42 PM, Markus Elfring wrote:
>>> Can it helpful to add jump targets so that a bit of exception handling
>>> can be better reused at the end of this function?
>> OK, no problem, I will do it in the v2.
> It seems that the software evolution will be continued with another
> update suggestion like the following.
>
> [PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks
> https://lore.kernel.org/linux-mips/1592984711-3130-11-git-send-email-yangtiezhu@loongson.cn/
> https://lore.kernel.org/patchwork/patch/1263191/
>
>
> Can it matter to omit the word “potential” from change descriptions
> after you detected that specific function calls were missing
> in if branches?

Oh, I find this issue through code review, I have no test environment
to trigger the error path, but I think it is better to release the resource
in the error path, so I use "potential" description.

>
> Regards,
> Markus