linux-kernel - Re: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU firmware driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Jun 2020 15:59:41 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Anson Huang <anson.huang@....com>
Cc:     Franck Lenormand <franck.lenormand@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Leo Li <leoyang.li@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "olof@...om.net" <olof@...om.net>,
        Leonard Crestez <leonard.crestez@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        Peng Fan <peng.fan@....com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        Daniel Baluta <daniel.baluta@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU firmware driver

On Wed, Jun 24, 2020 at 3:15 PM Anson Huang <anson.huang@....com> wrote:
>
> Hi, Franck/Arnd
>
> > Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU
> > firmware driver
> >
> > Hello,
> >
> > The move of folder is a good idea however I do not feel adding the code of
> > soc-imx-scu.c  to imx-scu.c is the best.
> > Until now imx-scu.c was focused on exchanging the RPC and init the IRQ.
> > Why not have soc-imx-scu.c  copied to imx-scu-soc.c (change filename) to
> > have a pattern similar to imx-scu-irq? And keep the  imx_scu_soc_init into
> > imx-scu.c.
> >
> Sound like making sense to me, it can make the code architecture more clear.
>
>         What do you think?

Yes, I agree that is a good idea.

        Arnd