linux-kernel - Re: [PATCH] mm/page_alloc: fix documentation error and remove magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200624142740.GO21350@casper.infradead.org>
Date:   Wed, 24 Jun 2020 15:27:40 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Rafael Aquini <aquini@...hat.com>
Cc:     Joel Savitz <jsavitz@...hat.com>, linux-kernel@...r.kernel.org,
        Vlastimil Babka <vbabka@...e.cz>,
        John Hubbard <jhubbard@...dia.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH] mm/page_alloc: fix documentation error and remove magic
 numbers

On Wed, Jun 24, 2020 at 10:26:26AM -0400, Rafael Aquini wrote:
> Joel's approach, however, makes sense if you consider it's generally a 
> good practice to get rid of the unnamed magic numbers anti-pattern.

But I don't.  I care about how easy it is to understand the code, not
conforming to some bullshit trendy word salad.