lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jun 2020 10:43:18 +0100 From: Daniel Thompson <daniel.thompson@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: jingoohan1@...il.com, dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Software Engineering <sbabic@...x.de> Subject: Re: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg On Wed, Jun 24, 2020 at 03:57:18PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump' > > Cc: <stable@...r.kernel.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> > Cc: Software Engineering <sbabic@...x.de> > Signed-off-by: Lee Jones <lee.jones@...aro.org> > --- > drivers/video/backlight/ili922x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > index cd41433b87aeb..26193f38234e7 100644 > --- a/drivers/video/backlight/ili922x.c > +++ b/drivers/video/backlight/ili922x.c > @@ -295,6 +295,8 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) > #ifdef DEBUG > /** > * ili922x_reg_dump - dump all registers > + * > + * @spi: pointer to the controller side proxy for an SPI slave device Similar to previous... and I also noticed that there are several other existing @spi descriptions in this file and it would be good to make them consistent. Daniel. > */ > static void ili922x_reg_dump(struct spi_device *spi) > { > -- > 2.25.1 >
Powered by blists - more mailing lists