lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jun 2020 10:43:43 +0100 From: Daniel Thompson <daniel.thompson@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: jingoohan1@...il.com, dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Jamey Hicks <jamey.hicks@...com>, Andrew Zabolotny <zap@...elink.ru> Subject: Re: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs On Wed, Jun 24, 2020 at 03:57:19PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' > drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' > > Cc: <stable@...r.kernel.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> > Cc: Jamey Hicks <jamey.hicks@...com> > Cc: Andrew Zabolotny <zap@...elink.ru> > Signed-off-by: Lee Jones <lee.jones@...aro.org> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org> > --- > drivers/video/backlight/backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 92d80aa0c0ef1..744ba58488e01 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); > * backlight_force_update - tell the backlight subsystem that hardware state > * has changed > * @bd: the backlight device to update > + * @reason: reason for update > * > * Updates the internal state of the backlight in response to a hardware event, > * and generate a uevent to notify userspace > @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); > * @devdata: an optional pointer to be stored for private driver use. The > * methods may retrieve it by using bl_get_data(bd). > * @ops: the backlight operations structure. > + * @props: pointer to backlight's properties structure. > * > * Creates and registers new backlight device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > -- > 2.25.1 >
Powered by blists - more mailing lists