linux-kernel - Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65cfbfa8-bbfe-e0d3-0255-cd3550ff09c8@infradead.org>
Date:   Thu, 25 Jun 2020 08:24:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Richard Weinberger <richard@....at>,
        Kees Cook <keescook@...omium.org>
Cc:     Richard Weinberger <richard.weinberger@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Prasad Sodagudi <psodagud@...eaurora.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Amit Daniel Kachhap <amit.kachhap@....com>,
        linux-kselftest <linux-kselftest@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

On 6/24/20 11:24 PM, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "Kees Cook" <keescook@...omium.org>
>> An: "Randy Dunlap" <rdunlap@...radead.org>
>> CC: "Richard Weinberger" <richard.weinberger@...il.com>, "richard" <richard@....at>, "Greg Kroah-Hartman"
>> <gregkh@...uxfoundation.org>, "Prasad Sodagudi" <psodagud@...eaurora.org>, "Sami Tolvanen" <samitolvanen@...gle.com>,
>> "Amit Daniel Kachhap" <amit.kachhap@....com>, "linux-kselftest" <linux-kselftest@...r.kernel.org>, "clang-built-linux"
>> <clang-built-linux@...glegroups.com>, "linux-kernel" <linux-kernel@...r.kernel.org>
>> Gesendet: Donnerstag, 25. Juni 2020 08:06:18
>> Betreff: Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups
> 
>> On Wed, Jun 24, 2020 at 06:45:47PM -0700, Randy Dunlap wrote:
>>> Looks like lkdtm/bugs.c needs to get/use arch/x86/include/asm/processor.h
>>> but it actually uses arch/x86/um/asm/processor*.h, which does not have the
>>> needed structs etc.
>>
>> Should I just test for !UML in bugs.c? (This is all for the
>> lkdtm_DOUBLE_FAULT() test.) I already do those kinds of checks for the
>> lkdtm_UNSET_SMEP() test. e.g.:
> 
> Just had a look. Yes, this sounds good to me. UML has CONFIG_X86_32=y but no GDT. :-)

Sounds good to me also. Thanks.

-- 
~Randy