linux-kernel - Re: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 10:42:29 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Bhanu Prakash Maiya <bhanumaiya@...omium.org>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org, "Lee Jones )" <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Raul E Rangel <rrangel@...omium.org>,
        Furquan Shaikh <furquan@...omium.org>,
        Duncan Laurie <dlaurie@...gle.com>,
        Eric Peers <epeers@...gle.com>, devicetree@...r.kernel.org,
        Bhanu Prakash Maiya <bhanumaiya@...gle.com>
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string
 "google,cros_ec_uart"

Hi Bhanu,

Thank you for the patch.

On 25/6/20 23:34, Bhanu Prakash Maiya wrote:
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
> 
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...gle.com>
> ---
> 
>  Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++--

txt bindings are somewhat deprecated now, this specific binding was already
converted to the new json-schema, although didn't land yet, you should base your
changes on that, you can pick the following patch:

https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200306085513.76024-1-ikjn@chromium.org/

Also, the kernel test robot, reported a build problem, so fix the problems on
the second version.

Thanks,
 Enric


>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 4860eabd0f729..ec8c5d7ecc266 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
>  Google's ChromeOS EC is a Cortex-M device which talks to the AP and
>  implements various function such as keyboard and battery charging.
>  
> -The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
> +The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the
>  compatible string used depends on the interface. Each connection method has
>  its own driver which connects to the top level interface-agnostic EC driver.
>  Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,10 @@ Required properties (SPI):
>  - compatible: "google,cros-ec-spi"
>  - reg: SPI chip select
>  
> +Required properties (UART):
> +- compatible: "google,cros-ec-uart"
> +- reg: UART baudrate, flowcontrol
> +
>  Required properties (RPMSG):
>  - compatible: "google,cros-ec-rpmsg"
>  
> @@ -72,5 +76,6 @@ spi@...b0000 {
>  	};
>  };
>  
> -
>  Example for LPC is not supplied as it is not yet implemented.
> +
> +Example for UART is not supplied as it is not yet implemented.
>