linux-kernel - RE: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002401d64b95$fd620c80$f8262580$@codeaurora.org>
Date:   Fri, 26 Jun 2020 14:14:16 +0530
From:   "Rakesh Pillai" <pillair@...eaurora.org>
To:     "'Douglas Anderson'" <dianders@...omium.org>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>
Cc:     "'Evan Green'" <evgreen@...omium.org>,
        "'Sibi Sankar'" <sibis@...eaurora.org>,
        "'Rob Herring'" <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp



> -----Original Message-----
> From: Douglas Anderson <dianders@...omium.org>
> Sent: Friday, June 26, 2020 1:47 AM
> To: Andy Gross <agross@...nel.org>; Bjorn Andersson
> <bjorn.andersson@...aro.org>
> Cc: Evan Green <evgreen@...omium.org>; Sibi Sankar
> <sibis@...eaurora.org>; Rakesh Pillai <pillair@...eaurora.org>; Douglas
> Anderson <dianders@...omium.org>; Rob Herring <robh+dt@...nel.org>;
> devicetree@...r.kernel.org; linux-arm-msm@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp
> 
> The WiFi supplies that were added recently can't have done anything
> useful because they were missing the "-supply" suffix.  Booting
> without the "-supply" suffix would give these messages:
> 
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-0.8-cx-mx not found,
> using dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.8-xo not found,
using
> dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.3-rfa not found,
using
> dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-3.3-ch0 not found,
> using dummy regulator
> 
> Let's add the "-supply" suffix.
> 
> Fixes: 1e7594a38f37 ("arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
Reviewed-by: Rakesh Pillai <pillair@...eaurora.org>

I missed this in the DTSI patch, while manually rebasing to the kernel tip.

> I don't have an IDP setup but I have a similar board.  Testing on IDP
> would, of course, be appreciated.
> 
> Repost because I screwed up the "after-the-cut" notes on first post.
> 
>  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 39dbfc89689e..472f7f41cc93 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -391,10 +391,10 @@ video-firmware {
> 
>  &wifi {
>  	status = "okay";
> -	vdd-0.8-cx-mx = <&vreg_l9a_0p6>;
> -	vdd-1.8-xo = <&vreg_l1c_1p8>;
> -	vdd-1.3-rfa = <&vreg_l2c_1p3>;
> -	vdd-3.3-ch0 = <&vreg_l10c_3p3>;
> +	vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>;
> +	vdd-1.8-xo-supply = <&vreg_l1c_1p8>;
> +	vdd-1.3-rfa-supply = <&vreg_l2c_1p3>;
> +	vdd-3.3-ch0-supply = <&vreg_l10c_3p3>;
>  	wifi-firmware {
>  		iommus = <&apps_smmu 0xc2 0x1>;
>  	};
> --
> 2.27.0.212.ge8ba1cc988-goog