| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <31059bad-54e1-58a7-6531-14e473950bc9@arm.com>
Date: Fri, 26 Jun 2020 10:41:15 +0100
From: Alexandru Elisei <alexandru.elisei@....com>
To: kernel test robot <lkp@...el.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kvmarm@...ts.cs.columbia.edu
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
maz@...nel.org, tglx@...utronix.de, jason@...edaemon.net,
yuzenghui@...wei.com, julien.thierry.kdev@...il.com,
will@...nel.org, catalin.marinas@....com
Subject: Re: [PATCH 2/2] irqchip/gic-v3: Support pseudo-NMIs when SCR_EL3.FIQ
== 0
Hi,
On 6/26/20 2:51 AM, kernel test robot wrote:
> Hi Alexandru,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on arm64/for-next/core]
> [also build test WARNING on tip/irq/core v5.8-rc2 next-20200625]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Alexandru-Elisei/irqchip-gic-v3-Support-pseudo-NMIs-when-SCR_EL3-FIQ-0/20200625-230144
> base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
> config: arm64-randconfig-r025-20200624 (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8911a35180c6777188fefe0954a2451a2b91deaf)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm64 cross compiling tool for clang build
> # apt-get install binutils-aarch64-linux-gnu
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
My mistake, I'll start compiling the kernel with clang too.
The register width for ICC_PMR_EL1 in the kernel is rather inconsistent: in
arch_gicv3.h, the accessors use 32 bits for the PMR value which gets casted to 64
bit by the {read,write}_sysreg_s macros anyway, in struct pt_regs the register is
64-bit, in __cpu_do_idle_irqprio it's declared as an unsigned long,
arch_local_irqs_{disable,enable} declares it as u32 and casts it to an unsigned
long when used by the inline assembly, the gicv3 irqchip driver uses it as a 32
bit variable.
I think the confusion stems from the fact that originally it was a 32 bit
register, but was changed to 64 bits in Arm IHI 0069E (January 2019).
I could cast it to an unsigned long in the inline assembly, but IMO that looks a
bit awkward. Before sending the patches I was considering changing it everywhere
to 64 bits, but Mark Rutland had a different idea. Mark, would you mind explaining
why keeping it 32 bit wide makes more sense?
Thanks,
Alex
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/arm64/kernel/asm-offsets.c:10:
> In file included from include/linux/arm_sdei.h:8:
> In file included from include/acpi/ghes.h:5:
> In file included from include/acpi/apei.h:9:
> In file included from include/linux/acpi.h:13:
> In file included from include/linux/irqdomain.h:35:
> In file included from include/linux/of.h:17:
> In file included from include/linux/kobject.h:20:
> In file included from include/linux/sysfs.h:16:
> In file included from include/linux/kernfs.h:13:
> In file included from include/linux/idr.h:15:
> In file included from include/linux/radix-tree.h:15:
> In file included from include/linux/rcupdate.h:26:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> 2 warnings generated.
> --
> In file included from drivers/power/supply/ltc2941-battery-gauge.c:12:
> In file included from include/linux/module.h:13:
> In file included from include/linux/stat.h:6:
> In file included from arch/arm64/include/asm/stat.h:12:
> In file included from include/linux/time.h:6:
> In file included from include/linux/seqlock.h:36:
> In file included from include/linux/spinlock.h:54:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> drivers/power/supply/ltc2941-battery-gauge.c:476:13: warning: cast to smaller integer type 'enum ltc294x_id' from 'const void *' [-Wvoid-pointer-to-enum-cast]
> info->id = (enum ltc294x_id)of_device_get_match_data(&client->dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 3 warnings generated.
> --
> In file included from drivers/power/supply/goldfish_battery.c:11:
> In file included from include/linux/module.h:13:
> In file included from include/linux/stat.h:6:
> In file included from arch/arm64/include/asm/stat.h:12:
> In file included from include/linux/time.h:6:
> In file included from include/linux/seqlock.h:36:
> In file included from include/linux/spinlock.h:54:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> drivers/power/supply/goldfish_battery.c:269:36: warning: unused variable 'goldfish_battery_acpi_match' [-Wunused-const-variable]
> static const struct acpi_device_id goldfish_battery_acpi_match[] = {
> ^
> 3 warnings generated.
> --
> In file included from drivers/power/supply/bq25890_charger.c:8:
> In file included from include/linux/module.h:13:
> In file included from include/linux/stat.h:6:
> In file included from arch/arm64/include/asm/stat.h:12:
> In file included from include/linux/time.h:6:
> In file included from include/linux/seqlock.h:36:
> In file included from include/linux/spinlock.h:54:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> drivers/power/supply/bq25890_charger.c:1060:36: warning: unused variable 'bq25890_acpi_match' [-Wunused-const-variable]
> static const struct acpi_device_id bq25890_acpi_match[] = {
> ^
> 3 warnings generated.
> --
> In file included from drivers/power/reset/vexpress-poweroff.c:8:
> In file included from include/linux/notifier.h:15:
> In file included from include/linux/rwsem.h:16:
> In file included from include/linux/spinlock.h:54:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> drivers/power/reset/vexpress-poweroff.c:124:10: warning: cast to smaller integer type 'enum vexpress_reset_func' from 'const void *' [-Wvoid-pointer-to-enum-cast]
> switch ((enum vexpress_reset_func)match->data) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 3 warnings generated.
> --
> In file included from arch/arm64/kernel/asm-offsets.c:10:
> In file included from include/linux/arm_sdei.h:8:
> In file included from include/acpi/ghes.h:5:
> In file included from include/acpi/apei.h:9:
> In file included from include/linux/acpi.h:13:
> In file included from include/linux/irqdomain.h:35:
> In file included from include/linux/of.h:17:
> In file included from include/linux/kobject.h:20:
> In file included from include/linux/sysfs.h:16:
> In file included from include/linux/kernfs.h:13:
> In file included from include/linux/idr.h:15:
> In file included from include/linux/radix-tree.h:15:
> In file included from include/linux/rcupdate.h:26:
> In file included from include/linux/irqflags.h:16:
>>> arch/arm64/include/asm/irqflags.h:45:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqon)
> ^
> arch/arm64/include/asm/irqflags.h:42:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> arch/arm64/include/asm/irqflags.h:67:10: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
> : "r" (pmr_irqoff)
> ^
> arch/arm64/include/asm/irqflags.h:64:29: note: use constraint modifier "w"
> __msr_s(SYS_ICC_PMR_EL1, "%0"),
> ^
> 2 warnings generated.
> arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: no previous prototype for function '__kernel_clock_gettime' [-Wmissing-prototypes]
> int __kernel_clock_gettime(clockid_t clock,
> ^
> arch/arm64/kernel/vdso/vgettimeofday.c:9:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __kernel_clock_gettime(clockid_t clock,
> ^
> static
> arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: no previous prototype for function '__kernel_gettimeofday' [-Wmissing-prototypes]
> int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
> ^
> arch/arm64/kernel/vdso/vgettimeofday.c:15:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
> ^
> static
> arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: no previous prototype for function '__kernel_clock_getres' [-Wmissing-prototypes]
> int __kernel_clock_getres(clockid_t clock_id,
> ^
> arch/arm64/kernel/vdso/vgettimeofday.c:21:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __kernel_clock_getres(clockid_t clock_id,
> ^
> static
> 3 warnings generated.
>
> vim +45 arch/arm64/include/asm/irqflags.h
>
> 12
> 13 /*
> 14 * Aarch64 has flags for masking: Debug, Asynchronous (serror), Interrupts and
> 15 * FIQ exceptions, in the 'daif' register. We mask and unmask them in 'dai'
> 16 * order:
> 17 * Masking debug exceptions causes all other exceptions to be masked too/
> 18 * Masking SError masks irq, but not debug exceptions. Masking irqs has no
> 19 * side effects for other flags. Keeping to this order makes it easier for
> 20 * entry.S to know which exceptions should be unmasked.
> 21 *
> 22 * FIQ is never expected, but we mask it when we disable debug exceptions, and
> 23 * unmask it at all other times.
> 24 */
> 25
> 26 /*
> 27 * CPU interrupt mask handling.
> 28 */
> 29 static inline void arch_local_irq_enable(void)
> 30 {
> 31 u32 pmr_irqon = GIC_PRIO_IRQON;
> 32
> 33 if (system_has_prio_mask_debugging()) {
> 34 u32 pmr = read_sysreg_s(SYS_ICC_PMR_EL1);
> 35 u32 pmr_irqoff = gic_prio_irqoff();
> 36
> 37 WARN_ON_ONCE(pmr != pmr_irqon && pmr != pmr_irqoff);
> 38 }
> 39
> 40 asm volatile(ALTERNATIVE(
> 41 "msr daifclr, #2 // arch_local_irq_enable",
> 42 __msr_s(SYS_ICC_PMR_EL1, "%0"),
> 43 ARM64_HAS_IRQ_PRIO_MASKING)
> 44 :
> > 45 : "r" (pmr_irqon)
> 46 : "memory");
> 47
> 48 pmr_sync();
> 49 }
> 50
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists