lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Jun 2020 08:26:31 -0700 From: Kees Cook <keescook@...omium.org> To: Lee Jones <lee.jones@...aro.org> Cc: arnd@...db.de, gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 04/10] misc: lkdtm: bugs: At least try to use popuated variable On Fri, Jun 26, 2020 at 02:05:19PM +0100, Lee Jones wrote: > The result may not be intereresting, but not using a set variable > is bad form and causes W=1 kernel builds to complain. > > Fixes the following W=1 warning(s): > > drivers/misc/lkdtm/bugs.c: In function ‘lkdtm_STACK_GUARD_PAGE_LEADING’: > drivers/misc/lkdtm/bugs.c:331:25: warning: variable ‘byte’ set but not used [-Wunused-but-set-variable] > 331 | volatile unsigned char byte; > | ^~~~ > drivers/misc/lkdtm/bugs.c: In function ‘lkdtm_STACK_GUARD_PAGE_TRAILING’: > drivers/misc/lkdtm/bugs.c:345:25: warning: variable ‘byte’ set but not used [-Wunused-but-set-variable] > 345 | volatile unsigned char byte; > | ^~~~ > > Cc: Kees Cook <keescook@...omium.org> > Signed-off-by: Lee Jones <lee.jones@...aro.org> Ah yeah, this looks like a reasonable way to deal with it. Thanks! Acked-by: Kees Cook <keescook@...omium.org> -- Kees Cook
Powered by blists - more mailing lists