linux-kernel - Re: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200626152923.GB177734@dell>
Date:   Fri, 26 Jun 2020 16:29:23 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     gregkh <gregkh@...uxfoundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sudeep Dutt <sudeep.dutt@...el.com>,
        Ashutosh Dixit <ashutosh.dixit@...el.com>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused
 variable 'ret'

On Fri, 26 Jun 2020, Arnd Bergmann wrote:

> On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@...aro.org> wrote:
> >
> > Hasn't been checked since its conception 2 years ago.
> >
> > Squashes W=1 warning:
> >
> >  drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’:
> >  drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >  617 | int ret;
> >  | ^~~
> >
> > Cc: Sudeep Dutt <sudeep.dutt@...el.com>
> > Cc: Ashutosh Dixit <ashutosh.dixit@...el.com>
> > Cc: Christian Borntraeger <borntraeger@...ibm.com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> This is a correct change, but I'd take it one step further and make the
> _vop_remove_device() function return 'void' if you don't mind
> respinning the patch.
> 
> Either way
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

Thanks.

Do you mind if I handle your request as a subsequent patch?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog