linux-kernel - Re: [PATCH 4.19 012/206] ALSA: hda/realtek - Introduce polarity for micmute LED GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jun 2020 15:30:05 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 4.19 012/206] ALSA: hda/realtek - Introduce polarity for
 micmute LED GPIO

On Thu, Jun 25, 2020 at 09:02:55PM +0200, Pavel Machek wrote:
>Hi!
>
>> Currently mute LED and micmute LED share the same GPIO polarity.
>>
>> So split the polarity for mute and micmute, in case they have different
>> polarities.
>
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -94,6 +94,7 @@ struct alc_spec {
>>
>>  	/* mute LED for HP laptops, see alc269_fixup_mic_mute_hook() */
>>  	int mute_led_polarity;
>> +	int micmute_led_polarity;
>>  	hda_nid_t mute_led_nid;
>>  	hda_nid_t cap_mute_led_nid;
>>
>
>This variable will be always zero in 4.19.130... so the patch does not
>really do anything.
>
>In mainline, commit 3e0650ab26e20 makes use of this variable.

I'll queue 3e0650ab26e20 for 4.19, thanks!

-- 
Thanks,
Sasha