linux-kernel - Re: [PATCH] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200627172130.GK2549@kadam>
Date:   Sat, 27 Jun 2020 20:21:30 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: rtl8188eu: remove unnecessary comments in
 hal8188e_phy_cfg.h

On Sat, Jun 27, 2020 at 05:15:44PM +0200, Michael Straube wrote:
> @@ -145,21 +138,7 @@ struct bb_reg_def {
>  				 */
>  };
>  
> -/*------------------------------Define structure----------------------------*/
> -
> -
> -/*------------------------Export global variable----------------------------*/
> -/*------------------------Export global variable----------------------------*/
> -
> -
> -/*------------------------Export Marco Definition---------------------------*/
> -/*------------------------Export Marco Definition---------------------------*/
> -
> -
> -/*--------------------------Exported Function prototype---------------------*/
> -/*  */
>  /*  BB and RF register read/write */

You can probably delete this line as well.  ;)

> -/*  */
>  
>  /* Read initi reg value for tx power setting. */
>  void rtl8192c_PHY_GetHWRegOriginalValue(struct adapter *adapter);

regards,
dan carpenter