linux-kernel - RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Jun 2020 22:51:44 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Dan Carpenter'" <dan.carpenter@...cle.com>
Cc:     "'Avri Altman'" <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        "'Kukjin Kim'" <kgene@...nel.org>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Kiwoong Kim'" <kwmad.kim@...sung.com>,
        "'Wei Yongjun'" <weiyongjun1@...wei.com>,
        <linux-scsi@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

Hi Dan

> -----Original Message-----
> The "head" pointer can't be NULL because it points to an address in the
middle
> of a ufs_hba struct.  Looking at this code, probably someone would wonder
if
> the intent was to check whether "hba" is NULL, but "hba"
> isn't NULL and the check can just be removed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
Please add Fixes: tag
With that
Acked-by: Alim Akhtar <alim.akhtar@...sung.com>

Thanks!

>  drivers/scsi/ufs/ufs-exynos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index
> 16544b3dad47..802f7de626e8 100644
> --- a/drivers/scsi/ufs/ufs-exynos.c
> +++ b/drivers/scsi/ufs/ufs-exynos.c
> @@ -264,7 +264,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs
> *ufs)
>  	u8 div = 0;
>  	int ret = 0;
> 
> -	if (!head || list_empty(head))
> +	if (list_empty(head))
>  		goto out;
> 
>  	list_for_each_entry(clki, head, list) {
> --
> 2.27.0