linux-kernel - RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <041e01d64cef$5a166480$0e432d80$@samsung.com>
Date:   Sun, 28 Jun 2020 07:26:29 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Dan Carpenter'" <dan.carpenter@...cle.com>
Cc:     "'Avri Altman'" <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        "'Kukjin Kim'" <kgene@...nel.org>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Kiwoong Kim'" <kwmad.kim@...sung.com>,
        "'Wei Yongjun'" <weiyongjun1@...wei.com>,
        <linux-scsi@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

Hi Dan,

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...cle.com>
> On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote:
> > Hi Dan
> >
> > > -----Original Message-----
> > > The "head" pointer can't be NULL because it points to an address in
the
> > middle
> > > of a ufs_hba struct.  Looking at this code, probably someone would
wonder
> > if
> > > the intent was to check whether "hba" is NULL, but "hba"
> > > isn't NULL and the check can just be removed.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > > ---
> > Please add Fixes: tag
> > With that
> > Acked-by: Alim Akhtar <alim.akhtar@...sung.com>
> 
> It's not a bug fix it's just a cleanup.
> 
Acked-by: Alim Akhtar <alim.akhtar@...sung.com>

Thanks!

> regards,
> dan carpenter