linux-kernel - Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159348736490.22355.10176976047581563338.b4-ty@oracle.com>
Date:   Mon, 29 Jun 2020 23:23:04 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Alim Akhtar <alim.akhtar@...sung.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-samsung-soc@...r.kernel.org,
        Avri Altman <avri.altman@....com>,
        linux-kernel@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

On Fri, 26 Jun 2020 13:51:33 +0300, Dan Carpenter wrote:

> The "head" pointer can't be NULL because it points to an address in
> the middle of a ufs_hba struct.  Looking at this code, probably someone
> would wonder if the intent was to check whether "hba" is NULL, but "hba"
> isn't NULL and the check can just be removed.

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check
      https://git.kernel.org/mkp/scsi/c/b7a80dac0f1f

-- 
Martin K. Petersen	Oracle Linux Engineering