linux-kernel - Re: [PATCH] mm: remove the redundancy code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2006291149040.1030250@chino.kir.corp.google.com>
Date:   Mon, 29 Jun 2020 11:50:15 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Su Hui <sh_def@....com>
cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] mm: remove the redundancy code

On Tue, 30 Jun 2020, Su Hui wrote:

> remove the redundancy code, the zone_start_pfn
> is assigned from zone->zone_start_pfn
> Signed-off-by: Su Hui <sh_def@....com>

I don't think this is redundant, it's used by memory hotplug when onlining 
new memory.

> ---
>  mm/page_alloc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3c4eb750a199..3372a8c9fbc4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6215,8 +6215,6 @@ void __meminit init_currently_empty_zone(struct zone *zone,
>  	if (zone_idx > pgdat->nr_zones)
>  		pgdat->nr_zones = zone_idx;
>  
> -	zone->zone_start_pfn = zone_start_pfn;
> -
>  	mminit_dprintk(MMINIT_TRACE, "memmap_init",
>  			"Initialising map node %d zone %lu pfns %lu -> %lu\n",
>  			pgdat->node_id,