linux-kernel - Re: [PATCH 03/20] misc: habanalabs: firmware_if: Add missing 'fw_name' and 'dst' entries to function header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 17:57:44 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Tomer Tayar <ttayar@...ana.ai>
Subject: Re: [PATCH 03/20] misc: habanalabs: firmware_if: Add missing
 'fw_name' and 'dst' entries to function header

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Looks as though documentation for these function arguments have
> been missing since the driver's inception last year.
>
> Fixes the following W=1 kernel build warnings:
>
>  drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'fw_name' not described in 'hl_fw_load_fw_to_device'
>  drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'dst' not described in 'hl_fw_load_fw_to_device'
>
> Cc: Oded Gabbay <oded.gabbay@...il.com>
> Cc: Tomer Tayar <ttayar@...ana.ai>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/misc/habanalabs/firmware_if.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b787..15e0793da6554 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -15,7 +15,10 @@
>
>  /**
>   * hl_fw_load_fw_to_device() - Load F/W code to device's memory.
> + *
>   * @hdev: pointer to hl_device structure.
> + * @fw_name: the firmware image name
> + * @dst: IO memory mapped address space to copy firmware to
>   *
>   * Copy fw code from firmware file to device memory.
>   *
> --
> 2.25.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>