linux-kernel - Re: [PATCH 07/20] misc: habanalabs: pci: Scrub documentation for non-present function argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFCwf115Hm+Rf7r0bZmMbnGgz6jUm=ZK=Zvij_aD1WKEBUvOGw@mail.gmail.com>
Date:   Mon, 29 Jun 2020 18:00:45 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Tomer Tayar <ttayar@...ana.ai>
Subject: Re: [PATCH 07/20] misc: habanalabs: pci: Scrub documentation for
 non-present function argument

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> 'dma_mask' is not passed directly into hl_pci_set_dma_mask() as
> an argument.  Instead, it is pulled from struct hl_device *hdev.
>
> Fixed the following W=1 warning:
>
>  drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask
>
> Cc: Oded Gabbay <oded.gabbay@...il.com>
> Cc: Tomer Tayar <ttayar@...ana.ai>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/misc/habanalabs/pci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/pci.c b/drivers/misc/habanalabs/pci.c
> index 24073e8eb8df9..61a8bb07262cf 100644
> --- a/drivers/misc/habanalabs/pci.c
> +++ b/drivers/misc/habanalabs/pci.c
> @@ -317,7 +317,6 @@ int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address,
>  /**
>   * hl_pci_set_dma_mask() - Set DMA masks for the device.
>   * @hdev: Pointer to hl_device structure.
> - * @dma_mask: number of bits for the requested dma mask.
>   *
>   * This function sets the DMA masks (regular and consistent) for a specified
>   * value. If it doesn't succeed, it tries to set it to a fall-back value
> --
> 2.25.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>