linux-kernel - Re: [RESEND 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jun 2020 11:26:22 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     lgirdwood@...il.com, broonie@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND 07/10] regulator: cpcap-regulator: Remove declared and
 set, but never used variable 'ignore'

* Lee Jones <lee.jones@...aro.org> [200625 19:18]:
> It's okay to not check the return value that you're not conserned
> about, however it is not okay to assign a variable and not check or
> use the result.
> 
> Fixes W=1 warnings(s):
> 
>  drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
>  172 | int error, ignore;
>  | ^~~~~~
>  drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’:
>  drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
>  196 | int error, ignore;

Acked-by: Tony Lindgren <tony@...mide.com>