linux-kernel - Re: [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 14:41:25 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase()

On Thu, Jun 25, 2020 at 9:17 PM Lee Jones <lee.jones@...aro.org> wrote:

> There isn't any code present within the current kernel to
> override this 'weak' function.  Besides returning '0', which
> is never checked anyway, the whole function appears to be
> superfluous.
>
> Consequently fixes W=1 warning:
>
>  drivers/regulator/dbx500-prcmu.c:113:27: warning: no previous prototype for ‘dbx500_regulator_testcase’ [-Wmissing-prototypes]
>  113 | int __attribute__((weak)) dbx500_regulator_testcase(
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij