linux-kernel - Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76a657ca-d30e-c5f2-f057-1c1bb7c8e1bf@broadcom.com>
Date:   Mon, 29 Jun 2020 09:54:20 -0700
From:   Scott Branden <scott.branden@...adcom.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Lee Jones <lee.jones@...aro.org>, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, linux-pwm@...r.kernel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Yendapally Reddy Dhananjaya Reddy 
        <yendapally.reddy@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when
 validating duty cycle



On 2020-06-29 9:45 a.m., Florian Fainelli wrote:
>
> On 6/29/2020 5:47 AM, Lee Jones wrote:
>> 'duty' here is an unsigned int, thus checking for <0 will always
>> evaluate to false.
>>
>> Fixes the following W=1 warning:
>>
>>   drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>>
>> Cc: Ray Jui <rjui@...adcom.com>
>> Cc: Scott Branden <sbranden@...adcom.com>
>> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@...adcom.com>
>> Cc: bcm-kernel-feedback-list@...adcom.com
>> Cc: linux-pwm@...r.kernel.org
>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of
> the define, if you also remove it you can add:
>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
We actually made this same change internally recently but hadn't 
upstreamed it yet.

Tested-by: Scott Branden <scott.branden@...adcom.com>