linux-kernel - Re: [PATCH 03/10] gpio: gpio-ml-ioh: Fix missing ':' in 'struct ioh_gpio_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200630140110.GT3703480@smile.fi.intel.com>
Date:   Tue, 30 Jun 2020 17:01:10 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH 03/10] gpio: gpio-ml-ioh: Fix missing ':' in 'struct
 ioh_gpio_reg_data

On Tue, Jun 30, 2020 at 02:33:38PM +0100, Lee Jones wrote:
> 'struct ioh_gpio_reg_data's 'ien_reg' property is missing a ':'
> which confuses the kerneldoc tooling/parsers/validators.
> 
> Replacing it squashes the following W=1 warning:
> 
>  drivers/gpio/gpio-ml-ioh.c:63: warning: Function parameter or member 'ien_reg' not described in 'ioh_gpio_reg_data'

Applied, thanks!

> 
> Cc: Andy Shevchenko <andy@...nel.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/gpio/gpio-ml-ioh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 92b6e958cfed5..53d4abefa6ff2 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -44,7 +44,7 @@ struct ioh_regs {
>  
>  /**
>   * struct ioh_gpio_reg_data - The register store data.
> - * @ien_reg	To store contents of interrupt enable register.
> + * @ien_reg:	To store contents of interrupt enable register.
>   * @imask_reg:	To store contents of interrupt mask regist
>   * @po_reg:	To store contents of PO register.
>   * @pm_reg:	To store contents of PM register.
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko