linux-kernel - RE: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR05MB4110250294454B9764958D4DDA6F0@VI1PR05MB4110.eurprd05.prod.outlook.com>
Date:   Tue, 30 Jun 2020 14:17:20 +0000
From:   Asmaa Mnebhi <Asmaa@...lanox.com>
To:     Lee Jones <lee.jones@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: RE: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI
 functions may not be use

Reviewed-by: Asmaa Mnebhi <asmaa@...lanox.com>

Thank you.

-----Original Message-----
From: Lee Jones <lee.jones@...aro.org> 
Sent: Tuesday, June 30, 2020 9:34 AM
To: linus.walleij@...aro.org; bgolaszewski@...libre.com
Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-gpio@...r.kernel.org; Lee Jones <lee.jones@...aro.org>; Asmaa Mnebhi <Asmaa@...lanox.com>
Subject: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use

... as is the case when !CONFIG_ACPI.

Fixes the following W=1 kernel build warning:

 drivers/gpio/gpio-mlxbf2.c:312:36: warning: ‘mlxbf2_gpio_acpi_match’ defined but not used [-Wunused-const-variable=]
 312 | static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = {  | ^~~~~~~~~~~~~~~~~~~~~~

Cc: Asmaa Mnebhi <Asmaa@...lanox.com>
Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
 drivers/gpio/gpio-mlxbf2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 94d5efce1721c..861a8d0a84be0 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -309,7 +309,7 @@ static int mlxbf2_gpio_resume(struct platform_device *pdev)  }  #endif
 
-static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = {
+static const struct acpi_device_id __maybe_unused 
+mlxbf2_gpio_acpi_match[] = {
 	{ "MLNXBF22", 0 },
 	{},
 };
--
2.25.1