linux-kernel - Re: [PATCH v2] Documentation: Coccinelle: fix typos and command example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efc8b0c9-db3b-3c9c-d876-897b53a9e278@infradead.org>
Date:   Tue, 30 Jun 2020 08:11:18 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Markus Elfring <Markus.Elfring@....de>, linux-doc@...r.kernel.org,
        Coccinelle <cocci@...teme.lip6.fr>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <michal.lkml@...kovi.net>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v2] Documentation: Coccinelle: fix typos and command
 example

On 6/30/20 5:23 AM, Markus Elfring wrote:
> …
>> +++ linux-next-20200629/Documentation/dev-tools/coccinelle.rst
> …> @@ -177,13 +177,13 @@ For example, to check drivers/net/wirele
>>  To apply Coccinelle on a file basis, instead of a directory basis, the
>>  following command may be used::
>>
>> -    make C=1 CHECK="scripts/coccicheck"
>> +    make C=1 CHECK="scripts/coccicheck" path/to/file.c
> 
> I would like to clarify further software design aspects around such make functionality.
> 
> We might stumble on different interpretations according to the wording “file basis”.
> Do you find a message like “make: Nothing to be done for 'path/to/file.c'.” interesting then?
> 
> * Would you like to add any links for information around the support for
>   source code checkers?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?id=7c30b859a947535f2213277e827d7ac7dcff9c84#n198
> 
> * How do you think about to enclose the path for the shown parameter
>   by single quotes instead of double quotes?
> 
> * Can such path specifications become more interesting occasionally
>   if also an other file extension would be chosen than “.c”?
>   Would you like to achieve any software extensions around suffix rules?
> 
> Regards,
> Markus

Markus:

Feel free to submit patches.

-- 
~Randy