linux-kernel - Re: [PATCH v14 1/4] power_supply: Add additional health properties to the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <938bd51f-0551-38f0-c17c-19c7b42ec411@ti.com>
Date:   Wed, 1 Jul 2020 11:39:33 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Ricardo Rivera-Matos <r-rivera-matos@...com>, <sre@...nel.org>,
        <pali@...nel.org>, <robh@...nel.org>
CC:     <afd@...com>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <sspatil@...roid.com>, Guru Das Srinagesh <gurus@...eaurora.org>
Subject: Re: [PATCH v14 1/4] power_supply: Add additional health properties to
 the header

Sebastian

On 6/30/20 4:54 PM, Ricardo Rivera-Matos wrote:
> From: Dan Murphy <dmurphy@...com>
>
> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>
> HEALTH_WARM, HEALTH_COOL, and HEALTH_HOT properties are taken
> from JEITA specification JISC8712:2015
>
> Acked-by: Andrew F. Davis <afd@...com>
> Tested-by: Guru Das Srinagesh <gurus@...eaurora.org>
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
>   Documentation/ABI/testing/sysfs-class-power | 3 ++-
>   drivers/power/supply/power_supply_sysfs.c   | 3 +++
>   include/linux/power_supply.h                | 3 +++
>   3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 216d61a22f1e..40213c73bc9c 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -205,7 +205,8 @@ Description:
>   		Valid values: "Unknown", "Good", "Overheat", "Dead",
>   			      "Over voltage", "Unspecified failure", "Cold",
>   			      "Watchdog timer expire", "Safety timer expire",
> -			      "Over current", "Calibration required"
> +			      "Over current", "Calibration required", "Warm",
> +			      "Cool", "Hot"
>   
>   What:		/sys/class/power_supply/<supply_name>/precharge_current
>   Date:		June 2017
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index bc79560229b5..4d6e1d5015d6 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -101,6 +101,9 @@ static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
>   	[POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE]   = "Safety timer expire",
>   	[POWER_SUPPLY_HEALTH_OVERCURRENT]	    = "Over current",
>   	[POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED]  = "Calibration required",
> +	[POWER_SUPPLY_HEALTH_WARM]		    = "Warm",
> +	[POWER_SUPPLY_HEALTH_COOL]		    = "Cool",
> +	[POWER_SUPPLY_HEALTH_HOT]		    = "Hot",
>   };
>   
>   static const char * const POWER_SUPPLY_TECHNOLOGY_TEXT[] = {
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index ac1345a48ad0..b5ee35d3c304 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -62,6 +62,9 @@ enum {
>   	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
>   	POWER_SUPPLY_HEALTH_OVERCURRENT,
>   	POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED,
> +	POWER_SUPPLY_HEALTH_WARM,
> +	POWER_SUPPLY_HEALTH_COOL,
> +	POWER_SUPPLY_HEALTH_HOT,
>   };
>   
>   enum {


Can you apply this patch?

We have other charger drivers we want to submit for review but they all 
depend on this single patch.

If you do not want to apply this patch then please let us know how we 
can submit our other drivers so that build bots don't start spamming us 
with build failures

Dan