linux-kernel - Re: [PATCH 1/2] regulator: fan53880: Add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 19:09:13 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Christoph Fritz <chf.fritz@...glemail.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support

On Tue, Jun 30, 2020 at 08:52:02PM +0200, Christoph Fritz wrote:
> This patch adds support for ON Semiconductor FAN53880 regulator.
> 
> The FAN53880 is an I2C porgrammable power management IC (PMIC)
> that contains a BUCK (step-down converter), four LDOs (low dropouts)
> and one BOOST (step-up converter).  It is designed for mobile power
> applications.

This doesn't build with current code, there are *many* errors in the
form

/mnt/kernel/drivers/regulator/fan53880.c:48:52: error: array type has incomplete element type 'struct regulator_linear_range'
   .linear_ranges =   (struct regulator_linear_range[]) { \
                                                    ^
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
In file included from /mnt/kernel/drivers/regulator/fan53880.c:5:
/mnt/kernel/include/linux/regulator/driver.h:46:2: error: field name not in record or union initializer
  .min  = _min_uV,     \
  ^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE'
         REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
         ^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:46:2: note: (near initialization for '(anonymous)')
  .min  = _min_uV,     \
  ^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE'
         REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
         ^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name not in record or union initializer
  .min_sel = _min_sel,     \
  ^

most likely due to the conversion introduced in 60ab7f4153b6af46
(regulator: use linear_ranges helper).  Please rebase against current
code.

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)