linux-kernel - Re: [PATCH 1/2] regulator: fan53880: Add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ee7829c08f45f5b6907877e0f3b11320c178867.camel@googlemail.com>
Date:   Thu, 02 Jul 2020 23:09:41 +0200
From:   Christoph Fritz <chf.fritz@...glemail.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support

On Wed, 2020-07-01 at 19:09 +0100, Mark Brown wrote:
> /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of
> macro 'FAN53880_LDO'
>   FAN53880_LDO(1, "VIN12", 2800000),
>   ^~~~~~~~~~~~
> /mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name
> not in record or union initializer
>   .min_sel = _min_sel,     \
>   ^
> 
> most likely due to the conversion introduced in 60ab7f4153b6af46
> (regulator: use linear_ranges helper).  Please rebase against current
> code.

Thanks for the hint, yeah that's it. After picking up a recent linux-
next and adapting it works on current too.

Please let me respin the patches in a v2.