linux-kernel - Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e8c07c8-0954-462a-cfe6-a1ccde1bedea@codeaurora.org>
Date:   Wed, 1 Jul 2020 16:50:39 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Rob Herring <robh@...nel.org>
Cc:     stanimir.varbanov@...aro.org, agross@...nel.org,
        bjorn.andersson@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mka@...omium.org
Subject: Re: [PATCH v2] dt-bindings: media: venus: Add an optional power
 domain for perf voting


On 6/1/2020 11:26 AM, Rajendra Nayak wrote:
> 
> On 5/28/2020 1:06 AM, Rob Herring wrote:
>> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
>>> Add an optional power domain which when specified can be used for
>>> setting the performance state of Venus.
>>>
>>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>>> ---
>>>   Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 6 +++++-
>>>   Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
>>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> index 764affa..ac1ed64 100644
>>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> @@ -25,12 +25,16 @@ properties:
>>>       maxItems: 1
>>>     power-domains:
>>> -    maxItems: 2
>>> +    minItems: 2
>>> +    maxItems: 3
>>>     power-domain-names:
>>> +    minItems: 2
>>> +    maxItems: 3
>>>       items:
>>>         - const: venus
>>>         - const: vcodec0
>>> +      - const: opp-pd
>>
>> Humm, looks suspicious. This is a phyical power island in this block?
> 
> yes, this is used to represent the physical 'cx' power island in the SoC
> (Its a shared power island, not a power island specific to this block)
> that can be scaled to different 'performance levels' based on the frequency
> the codec is expected to run at.

Rob, Did you have any other concerns here? Should I be re-posting this?

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation