lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jul 2020 15:09:37 +0200 From: Matthias Brugger <matthias.bgg@...il.com> To: Lee Jones <lee.jones@...aro.org>, ulf.hansson@...aro.org Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Chaotian Jing <chaotian.jing@...iatek.com>, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header On 01/07/2020 14:46, Lee Jones wrote: > No other function in the file is documented using kerneldoc and no > effort to document the function arguments have been made. It's a > bit of an oddity to say the least. Let's downgrade it from > kerneldoc to a standard comment block instead. > > Fixes the following W=1 kernel build warning: > > drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq' > > Cc: Chaotian Jing <chaotian.jing@...iatek.com> > Cc: Matthias Brugger <matthias.bgg@...il.com> > Cc: linux-mediatek@...ts.infradead.org > Signed-off-by: Lee Jones <lee.jones@...aro.org> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com> > --- > drivers/mmc/host/mtk-sd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 39e7fc54c438f..49ac802ebbfeb 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events, > return cmd->error; > } > > -/** > +/* > * msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost > * > * Host controller may lost interrupt in some special case. > * Add SDIO irq recheck mechanism to make sure all interrupts > * can be processed immediately > - * > */ > static void msdc_recheck_sdio_irq(struct msdc_host *host) > { >
Powered by blists - more mailing lists