linux-kernel - Re: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down to basic comment block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jul 2020 09:43:19 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Lee Jones <lee.jones@...aro.org>, ulf.hansson@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Ritesh Harjani <riteshh@...eaurora.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>
Subject: Re: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down
 to basic comment block

On 1/07/20 3:47 pm, Lee Jones wrote:
> cqhci_host_alloc_tdl()'s function header is the only one in
> kerneldoc format.  Which seems odd as it's not part of an
> external API and isn't referenced anywhere else.  Seeing as
> there has also been no attempt to describe the expected
> function arguments either, we're going to assume that this is
> not actually a bona fide kerneldoc use-case.
> 
> Fixes the following W=1 kernel build warning:
> 
>  drivers/mmc/host/cqhci.c:163: warning: Function parameter or member 'cq_host' not described in 'cqhci_host_alloc_tdl'
> 
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ritesh Harjani <riteshh@...eaurora.org>
> Cc: Asutosh Das <asutoshd@...eaurora.org>
> Cc: Venkat Gopalakrishnan <venkatg@...eaurora.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 75934f3c117eb..8cc277b4ffe9e 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -144,7 +144,7 @@ static void cqhci_dumpregs(struct cqhci_host *cq_host)
>  		CQHCI_DUMP(": ===========================================\n");
>  }
>  
> -/**
> +/*
>   * The allocated descriptor table for task, link & transfer descritors
>   * looks like:
>   * |----------|
>