linux-kernel - Re: [PATCH] mfd: lm3533: expand control-bank accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200701135459.GH1179328@dell>
Date:   Wed, 1 Jul 2020 14:54:59 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: lm3533: expand control-bank accessors

On Tue, 30 Jun 2020, Johan Hovold wrote:

> Expand the control-bank accessors that were implemented using macros.
> This allows the definitions of these exported functions to be found more
> easily and specifically avoids a W=1 compiler warning due to the
> redundant brightness sanity check:
> 
> drivers/mfd/lm3533-ctrlbank.c: In function 'lm3533_ctrlbank_set_brightness':
> drivers/mfd/lm3533-ctrlbank.c:98:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
>    98 |  if (val > LM3533_##_NAME##_MAX)     \
>       |          ^
> drivers/mfd/lm3533-ctrlbank.c:125:1: note: in expansion of macro 'lm3533_ctrlbank_set'
>   125 | lm3533_ctrlbank_set(brightness, BRIGHTNESS);
>       | ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/mfd/lm3533-ctrlbank.c | 94 +++++++++++++++++++++--------------
>  1 file changed, 56 insertions(+), 38 deletions(-)

That'll work.  Thanks Johan.

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog