linux-kernel - Re: [PATCH 17/26] mm/riscv: Use general page fault accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200702155132.GJ40675@xz-x1>
Date:   Thu, 2 Jul 2020 11:51:32 -0400
From:   Peter Xu <peterx@...hat.com>
To:     Pekka Enberg <penberg@...il.com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Gerald Schaefer <gerald.schaefer@...ibm.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Will Deacon <will@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 17/26] mm/riscv: Use general page fault accounting

On Wed, Jul 01, 2020 at 02:46:24PM +0300, Pekka Enberg wrote:
> Hi Peter,

Hi, Pekka,

> 
> On Sat, Jun 27, 2020 at 1:36 AM Peter Xu <peterx@...hat.com> wrote:
> > Use the general page fault accounting by passing regs into handle_mm_fault().
> > It naturally solve the issue of multiple page fault accounting when page fault
> > retry happened.
> 
> I sent a patch to fix up riscv page fault accounting some days ago:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2020-June/000775.html

Yes, this is a valid fix too.

> 
> However, your fix is obviously even better. For the generic and riscv parts:
> 
> Reviewed-by: Pekka Enberg <penberg@...nel.org>

Thanks!

-- 
Peter Xu