linux-kernel - Re: [PATCH v6 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007022345.5ZAMQFKJ%lkp@intel.com>
Date:   Thu, 2 Jul 2020 23:52:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vinay Simha BN <simhavcs@...il.com>
Cc:     kbuild-all@...ts.01.org, Vinay Simha BN <simhavcs@...il.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v6 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Hi Vinay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vinay-Simha-BN/dt-binding-Add-DSI-LVDS-TC358775-bridge-bindings/20200702-203915
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd77006e01b3198c75fb7819b3d0ff89709539bb
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/tc358775.c:527:1: warning: no previous prototype for 'tc_mode_valid' [-Wmissing-prototypes]
     527 | tc_mode_valid(struct drm_bridge *bridge,
         | ^~~~~~~~~~~~~
   drivers/gpu/drm/bridge/tc358775.c:662:16: error: initialization of 'enum drm_mode_status (*)(struct drm_bridge *, const struct drm_display_mode *)' from incompatible pointer type 'enum drm_mode_status (*)(struct drm_bridge *, const struct drm_display_info *, const struct drm_display_mode *)' [-Werror=incompatible-pointer-types]
     662 |  .mode_valid = tc_mode_valid,
         |                ^~~~~~~~~~~~~
   drivers/gpu/drm/bridge/tc358775.c:662:16: note: (near initialization for 'tc_bridge_funcs.mode_valid')
   cc1: some warnings being treated as errors

vim +/tc_mode_valid +527 drivers/gpu/drm/bridge/tc358775.c

   525	
   526	enum drm_mode_status
 > 527	tc_mode_valid(struct drm_bridge *bridge,
   528		      const struct drm_display_info *info,
   529		      const struct drm_display_mode *mode)
   530	{
   531		struct tc_data *tc = bridge_to_tc(bridge);
   532	
   533		/*
   534		 * Maximum pixel clock speed 135MHz for single-link
   535		 * 270MHz for dual-link
   536		 */
   537		if ((mode->clock > 135000 && tc->dual_link) ||
   538		    (mode->clock > 270000 && tc->dual_link))
   539			return MODE_CLOCK_HIGH;
   540	
   541		return MODE_OK;
   542	}
   543	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67092 bytes)