linux-kernel - Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200702135054.GA29240@lst.de>
Date:   Thu, 2 Jul 2020 15:50:54 +0200
From:   Christoph Hellwig <hch@....de>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 16/23] seq_file: switch over direct seq_read method
 calls to seq_read_iter

On Thu, Jul 02, 2020 at 11:46:17AM +0200, Miguel Ojeda wrote:
> Hi Christoph,
> 
> On Wed, Jul 1, 2020 at 10:25 PM Christoph Hellwig <hch@....de> wrote:
> >
> > Switch over all instances used directly as methods using these sed
> > expressions:
> >
> > sed -i -e 's/\.read\(\s*=\s*\)seq_read/\.read_iter\1seq_read_iter/g'
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
> 
> Nit: the replacements don't take into account the spaces/tabs needed
> to align the designated initializers.

Do you have a suggestion for an automated replacement which does?
I'll happily switch over to that.