linux-kernel - Re: [PATCH 19/23] sysctl: Call sysctl_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jul 2020 02:34:41 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Christoph Hellwig <hch@....de>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error

On Thu, Jul 02, 2020 at 07:15:12AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 02, 2020 at 01:32:40AM +0100, Matthew Wilcox wrote:
> > On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote:
> > > From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > > 
> > > This error path returned directly instead of calling sysctl_head_finish().
> > > 
> > > Fixes: ef9d965bc8b6 ("sysctl: reject gigantic reads/write to sysctl files")
> > > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> > 
> > I think this one needs to go to Linus before 5.8, not get stuck in the
> > middle of a large patch series.
> 
> I've only kept it here because it didn't show up in Linus tree yet.
> If you send it and it gets picked up I can trivially drop it.

I'll send it tonight, if it's not there yet...